Skip to content

update --rm cmd help info#4384

Merged
Cyan4973 merged 1 commit into
facebook:devfrom
xiaoge1001:dev
Jun 8, 2025
Merged

update --rm cmd help info#4384
Cyan4973 merged 1 commit into
facebook:devfrom
xiaoge1001:dev

Conversation

@xiaoge1001

Copy link
Copy Markdown

Starting from cee6bec, --rm is ignored when the output is stdout.

@facebook-github-bot

Copy link
Copy Markdown

Hi @xiaoge1001!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@xiaoge1001 xiaoge1001 changed the title update --rm help info update --rm cmd help info May 9, 2025
@xiaoge1001 xiaoge1001 closed this May 10, 2025
@xiaoge1001 xiaoge1001 reopened this May 10, 2025
@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Comment thread programs/zstdcli.c Outdated
DISPLAY_F(f, " -o OUTPUT Write output to a single file, OUTPUT.\n");
DISPLAY_F(f, " -k, --keep Preserve INPUT file(s). [Default] \n");
DISPLAY_F(f, " --rm Remove INPUT file(s) after successful (de)compression.\n");
DISPLAY_F(f, " --rm Remove INPUT file(s) after successful (de)compression. Ignoring `--rm` command when the output is `stdout`.\n");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For zstd -h, we try to keep displayed lines short, for a good terminal experience.
So I would try to shorten this one if possible, for example:
Remove INPUT file(s) after successful (de)compression to file.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have already made the necessary modifications.

@Cyan4973 Cyan4973 self-assigned this May 29, 2025
Starting from cee6bec, --rm is ignored when the output is `stdout`.
@Cyan4973
Cyan4973 merged commit ec8ad2e into facebook:dev Jun 8, 2025
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants